Skip to content

MSC4108 support OIDC QR code login#4134

Merged
t3chguy merged 101 commits intodevelopfrom
t3chguy/oidc-qr-prototyping
Jun 6, 2024
Merged

MSC4108 support OIDC QR code login#4134
t3chguy merged 101 commits intodevelopfrom
t3chguy/oidc-qr-prototyping

Conversation

@t3chguy
Copy link
Copy Markdown
Member

@t3chguy t3chguy commented Mar 25, 2024

No description provided.

hughns and others added 22 commits March 14, 2024 11:32
@hughns
Nonce is optional or not present in the id_token depending on the gra…
151349f 
…nt type
@hughns
Prototype for MSC4108
9f8b29d 
Known limitations of the prototype are marked with PROTOTYPE comments
@hughns
misc
62e3982
@t3chguy
Remove redundant change
7c07234 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Tweak rendezvous index
582350f 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to using rust-crypto backed SecureChannel implementation for M…
964020a 
…SC4108

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Remove debug logging
f2ab31b 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Iterate PR
a3be3a9 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Tweak getPostEndpoint
8a57f92 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Switch to generating/parsing MSC4108 QR codes via Rust Crypto
3ffd014 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Discard changes to src/crypto/verification/QRCode.ts
c59d4b4
@hughns
Label flows and merge steps 2 and 3
16db19f
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-js-sdk into hu…
784137b 
…ghns/oidc-qr-prototyping
@t3chguy
Wire up rust-crypto qr secrets import/export
168e005 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-js-sdk into hu…
73ff790 
…ghns/oidc-qr-prototyping
@t3chguy
Remove spurious console log
956af05 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-js-sdk into hu…
9add919 
…ghns/oidc-qr-prototyping

# Conflicts:
#	src/crypto/index.ts
@t3chguy
Free rust crypto structures
c03d746 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Fix free throwing an error
28980c0 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Check IdP supports device_code scope before requesting it
9a00126 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
prettier
6b01af2 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Remove changes which rely on major oidc-client-ts upstream changes
cf999b7 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy mentioned this pull request Mar 25, 2024
Merged
t3chguy and others added 6 commits March 25, 2024 18:26
@t3chguy
Fix copyrights
a490ebf 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-js-sdk into t3…
296ef6f 
…chguy/oidc-qr-prototyping
@t3chguy
Make tsc happier
42953c8 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-js-sdk into t3…
d1bc600 
…chguy/oidc-qr-prototyping
@hughns @t3chguy
Rename m.login.accepted to m.login.protocol_accepted
a839a11 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Improve test coverage
e414067 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from dbkr May 29, 2024 15:12
@t3chguy
Add comments
6f253e6 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Copy link
Copy Markdown
Member Author

t3chguy commented May 30, 2024

Sorry, I'm not going to be able to review this as it stands. Please break it up.

@richvdh you are only asked to review the crypto related bits to fulfil the CODEOWNERS requirement.

I have provided the links to the corresponding files for your convenience:

https://github.com/matrix-org/matrix-js-sdk/pull/4134/files#diff-1cdf58640fc7d7c465fab943126da6a0d5c9ab99301676278fdc362beea10c11
https://github.com/matrix-org/matrix-js-sdk/pull/4134/files#diff-55b0e7275b7510d86f5e201e7b377396032f2fe5f040c9681fb75d40213d2c01
https://github.com/matrix-org/matrix-js-sdk/pull/4134/files#diff-6eb6c51bc52963382d87f0e413ae91df69b9c8426285c367e27f0328db33360b
https://github.com/matrix-org/matrix-js-sdk/pull/4134/files#diff-ca8741e6064cda5d26243ec210815e74962e5617951c9ec99ef4877dad964b38
https://github.com/matrix-org/matrix-js-sdk/pull/4134/files#diff-890ab04f8e5e8b612d0069bf0c681ef35d1ef3810abba98205ee464f3c366577

PS this is already a lean version of the original PR, just with a plethora of tests and comments added which bloats it.

@t3chguy t3chguy requested a review from richvdh May 30, 2024 12:27
@t3chguy
Correctly handle m.login.declined after MSC clarification
e4a6209 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Iterate
1c9cce8 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy mentioned this pull request Jun 3, 2024
Merged
@richvdh
Copy link
Copy Markdown
Member

richvdh commented Jun 3, 2024

Let's land #4227 and then see where we are

@richvdh richvdh removed their request for review June 3, 2024 12:24
t3chguy added 2 commits June 5, 2024 11:46
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-js-sdk into t3…
71cfa80 
…chguy/oidc-qr-prototyping

# Conflicts:
#	spec/unit/rust-crypto/rust-crypto.spec.ts
@t3chguy
Iterate
bdb24b4 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy added 2 commits June 5, 2024 11:59
@t3chguy
Iterate
039f897 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Iterate
8332cd0 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added this pull request to the merge queue Jun 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024
@t3chguy t3chguy mentioned this pull request Jun 5, 2024
Merged
@t3chguy
Merge branch 'develop' of github.com:matrix-org/matrix-js-sdk into t3…
6f1ae84 
…chguy/oidc-qr-prototyping

# Conflicts:
#	src/rendezvous/RendezvousFailureReason.ts
@t3chguy t3chguy added this pull request to the merge queue Jun 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 6, 2024
@t3chguy t3chguy merged commit 6436fbb into develop Jun 6, 2024
@t3chguy t3chguy deleted the t3chguy/oidc-qr-prototyping branch June 6, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richvdh richvdh richvdh left review comments

@dbkr dbkr dbkr approved these changes

@hughns hughns hughns approved these changes

@uhoreg uhoreg Awaiting requested review from uhoreg uhoreg was automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees

@t3chguy t3chguy

Labels

T-Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@t3chguy @richvdh @dbkr @hughns